Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggle all RISE buttons on slides #6

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

YiqinZhang
Copy link

Fix toggle all RISE buttons and hard-wire both keyboards "m" and "," to hide/show buttons on the slideshow.

@YiqinZhang YiqinZhang changed the title Dev Fix toggle all RISE buttons on slides Aug 29, 2022
@fcollonval
Copy link
Owner

Hey @YiqinZhang what is the reason behind adding m - it seems that in the notebook extension only , is used.

@YiqinZhang
Copy link
Author

YiqinZhang commented Sep 13, 2022

Hi @fcollonval . Thank you fro your reply.
When I bound the shortcut to toggle the buttons, I found in rise.yaml and main.js, m was supposed to assign to toggleAllRiseButtons or at some point in time. So I added m to simulate the action. Nevertheless, I revised it to , and updated the pr.

@YiqinZhang
Copy link
Author

Hi @fcollonval, I made some changes, and it's ready for review.

@fcollonval
Copy link
Owner

Thanks @YiqinZhang

As you stated earlier, m was assign at some point but now only , is binded. So thanks for changing the code to keep only ,.

@fcollonval fcollonval merged commit 023fd81 into fcollonval:ft/jlab3 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants