gatherSum(_integral_value) should not be in getValue()

otherwise, you will get a different value when call getValue() again Refs idaholab#13252
fdkong · May 2, 2019 · 14859f3 · 14859f3
1 parent 55632f1
commit 14859f3
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 5 deletions.
diff --git a/framework/include/postprocessors/SideIntegralPostprocessor.h b/framework/include/postprocessors/SideIntegralPostprocessor.h
@@ -33,6 +33,7 @@ class SideIntegralPostprocessor : public SidePostprocessor
   virtual void execute() override;
   virtual Real getValue() override;
   virtual void threadJoin(const UserObject & y) override;
+  virtual void finalize() override;
 
 protected:
   virtual Real computeQpIntegral() = 0;

diff --git a/framework/include/userobject/ElementIntegralUserObject.h b/framework/include/userobject/ElementIntegralUserObject.h
@@ -34,7 +34,7 @@ class ElementIntegralUserObject : public ElementUserObject
   virtual void initialize() override;
   virtual void execute() override;
   virtual void threadJoin(const UserObject & y) override;
-  virtual void finalize() override {}
+  virtual void finalize() override;
 
   /// Returns the integral value
   virtual Real getValue();

diff --git a/framework/include/userobject/SideIntegralUserObject.h b/framework/include/userobject/SideIntegralUserObject.h
@@ -33,7 +33,7 @@ class SideIntegralUserObject : public SideUserObject
   virtual void initialize() override;
   virtual void execute() override;
   virtual void threadJoin(const UserObject & y) override;
-  virtual void finalize() override {}
+  virtual void finalize() override;
 
   /// Returns the integral value
   virtual Real getValue();

diff --git a/framework/src/postprocessors/SideIntegralPostprocessor.C b/framework/src/postprocessors/SideIntegralPostprocessor.C
@@ -39,10 +39,15 @@ SideIntegralPostprocessor::execute()
 Real
 SideIntegralPostprocessor::getValue()
 {
-  gatherSum(_integral_value);
   return _integral_value;
 }
 
+void
+SideIntegralPostprocessor::finalize()
+{
+  gatherSum(_integral_value);
+}
+
 void
 SideIntegralPostprocessor::threadJoin(const UserObject & y)
 {

diff --git a/framework/src/userobject/ElementIntegralUserObject.C b/framework/src/userobject/ElementIntegralUserObject.C
@@ -40,10 +40,15 @@ ElementIntegralUserObject::execute()
 Real
 ElementIntegralUserObject::getValue()
 {
-  gatherSum(_integral_value);
   return _integral_value;
 }
 
+void
+ElementIntegralUserObject::finalize()
+{
+  gatherSum(_integral_value);
+}
+
 void
 ElementIntegralUserObject::threadJoin(const UserObject & y)
 {

diff --git a/framework/src/userobject/SideIntegralUserObject.C b/framework/src/userobject/SideIntegralUserObject.C
@@ -39,10 +39,15 @@ SideIntegralUserObject::execute()
 Real
 SideIntegralUserObject::getValue()
 {
-  gatherSum(_integral_value);
   return _integral_value;
 }
 
+void
+SideIntegralUserObject::finalize()
+{
+  gatherSum(_integral_value);
+}
+
 void
 SideIntegralUserObject::threadJoin(const UserObject & y)
 {