Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --cwd in hxml projects #2052

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Conversation

romamik
Copy link
Contributor

@romamik romamik commented Feb 26, 2018

This should fix #2051
This is my first code in C# for very long time. Also I did not manage to properly test this. But I've opened my project and it worked.

@SlavaRa
Copy link

SlavaRa commented Feb 27, 2018

it is fixed in #1827

@romamik
Copy link
Contributor Author

romamik commented Feb 27, 2018

@SlavaRa I briefly looked at your pull-request. Are you sure it adds support for --cwd? Support for sub-hxmls is already there in actual release, but that's not enough.

What are the chances your PR will be merged? It's quite old...

offtopic: can I just replace compiled binaries in my installation of flashdevelop? I would like to switch to version with that fixed...

@romamik
Copy link
Contributor Author

romamik commented Mar 2, 2018

@SlavaRa I've tested your pull request, and it does not solve my issue.

I've created small test project. FlashDevelop project is in folder2 folder.
fdTestHxml.zip

This is how it looks with your pull request
image

And this is how it looks with mine:
image

PS Also I've noticed that .hxml file should be in same directory as flashdevelop project. That also should be fixed IMHO, but this looks like seperate issue

@SlavaRa
Copy link

SlavaRa commented Mar 3, 2018

Ok, thanks, I'll review this PR tomorrow.

@SlavaRa SlavaRa added the haxe label Jun 26, 2018
@SlavaRa SlavaRa merged commit 61e395a into fdorg:development Jul 30, 2018
@romamik romamik deleted the romamik_hxml_cwd branch July 30, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--cwd in hxml is not supported in haxe hxml projects
2 participants