-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote-http
online store
#4121
Comments
remote-http
and remote-grpc
online storesremote-http
online store
I am currently working on this and will get back in case if i find any difficulty. |
Some things we'll have to do:
We'll have to serialize the data on the server to match what's in the feature registry from the |
@franciscojavierarceo I think you closed this by accident.
Is this something we support? The signature for |
Whoops, nevermind that was based on outdated documentation I think. |
@tokoko I'm confused about why we would do this? I think adding a client that makes the behavior intuitive makes sense but that's basically in the Python feature server. |
Well, it's more of convenience thing, i think. They can still use the feature server directly of course, but what this additional layer would enable is writing a piece of code using |
Few updates after started working on the issue:
|
@tokoko can you confirm the above assumptions, in order to guide @lokeshrangineni 's implementation? |
sure, sounds like a good starting point. |
Created a draft PR just for initial feedback. Please note that code may change significantly depending on the feedback. |
Is your feature request related to a problem? Please describe.
Users can deploy http and grpc feature servers that wrap
get_online_features
calls, but currently there is no way to interact with feature servers from python sdk.Describe the solution you'd like
Add online store types
remote-http
andremote-grpc
(or maybe just call it aremote
and differentiate with a url?) that wrap network calls to the respective feature servers. This follows the same pattern as remote registry implementation that wraps calls to the registry server.The text was updated successfully, but these errors were encountered: