Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_materialization for Remote Registry fails for Stream Feature Views #4271

Open
msistla96 opened this issue Jun 12, 2024 · 0 comments
Open

Comments

@msistla96
Copy link
Contributor

Expected Behavior

apply_materialization for Remote Registry should work for Stream Feature Views. Discovered as part of #4257 when running integration tests.

Current Behavior

apply_materialization for Remote Registry throws the below error when trying to materialize a stream feature view:
TypeError: Parameter to MergeFrom() must be instance of same class: expected <class 'feast.core.FeatureView_pb2.FeatureView'> got <class 'feast.core.StreamFeatureView_pb2.StreamFeatureView'>.

Steps to reproduce

  1. Setup Remote Registry
  2. Call apply_materialization and pass a stream feature view as the feature view.

Specifications

  • Version: Python 3.9
  • Platform: Mac OSX
  • Subsystem: Sonoma 14.4.1

Possible Solution

ApplyMaterializationRequest of the RegistryServer proto should be updated to allow the StreamFeatureView proto to be passed when making the request from Remote Registry via RegistryServer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant