-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to have a test for main feast dependency before release/deployment #4344
Comments
Not exactly the same, but this can be mostly covered by #4185 I think. |
We should have the quickstart run before the release as well: https://docs.feast.dev/getting-started/quickstart |
What module would you import, how can we know the modules to validate? I tried with the blamed version 0.39.0: % pip install -q feast==0.39.0
% feast version
Feast SDK Version: "0.39.0"
% python -c "import feast"
% python -c "import sqlite_vect"
Traceback (most recent call last):
File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'sqlite_vect' |
You have a typo in "vec" |
But this CI validation would ideally run on all of the extras. |
% python -c "import sqlite_vec"
Traceback (most recent call last):
File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'sqlite_vec'
@franciscojavierarceo I need your feedback to move on with this solution. Thanks! |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
As seen in #4293, the PyPi package failed because of a dependency in a feast installation that uses an extra.
This can be added to the existing build_wheels ci by testing a python import. If the import fails, we should fail the build/release.
Describe alternatives you've considered
We should have the CI test building the main feast package before release/deployment as well each extra/add-on.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: