send back to server additional fields in 'params' besides 'query'

[beeplin]

Currently only params.query is sent back to server and other fields in params are discarded. I guess this is for avoiding conflicts when people try to send back fields like params.token or params.user which are already used for certain purposes. But it brings some inconveniences when we want to send additional information back to server (mostly used for hooks). Currently we have to put the additional information in query under some self-defined fields (like query.$populate etc.) and then on the server-side we have to use a self-defined before hook to extract the information out of the query object. The whole process seems awkward and unnatural.

So it would be wonderful if we also allow another certain field (could be named as params.options or something) sent back to server together with params.query. The field name (for example, options) is given, so we don't need to worry about conflicts.

[marshallswain]

It's a good idea to stick this in a separate key. I'd prefer that it were params.client or something that more explicitly states that those params aren't secure. This would at least save the step of having to create a hook to pull them off the query and stick them on hook.params.

[eddyystop]

I like client. I've been using clientParams.

On Thu, Nov 17, 2016 at 11:19 AM, Marshall Thompson <
notifications@github.com> wrote:

It's a good idea to stick this in a separate key. I'd prefer that it were
params.client or something that more explicitly states that those params
aren't secure.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#115 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABezn9ZtdJexj4Sb0DzSPXjY251IAJRAks5q_H6dgaJpZM4K1dSe
.

[daffl]

This is already being tracked with some good suggestions in feathersjs/feathers#304.

[daffl]

I'm going to close this as a duplicate of feathersjs/feathers#304 to keep all future discussion there. I'll definitely put this for the next release though.