Skip to content
This repository has been archived by the owner on Sep 4, 2019. It is now read-only.

Remove reference to typings/index.d.ts #119

Merged
merged 1 commit into from
Nov 25, 2016

Conversation

ninachaubal
Copy link
Contributor

Summary

Typings installs our dependencies in the project folder instead of the feathers-client folder, so we don't need this reference to the local typings.

@daffl
Copy link
Member

daffl commented Nov 25, 2016

Thank you! I'm still not sure why the PRs are failing but it'll probably pass again once it is in master. I'm not very familiar with Typescript, so if we merge this and make a release it'll pull in typings for the client automatically right?

Also, related to this: feathersjs/feathers#381. We'll definitely release these client typings but I'm just linking it so that we can revisit if/when we have typings in core that the client can extend.

@ninachaubal
Copy link
Contributor Author

Yup, it should pull it for the client. I have tested this on a separate feathers/angular2 app.

@daffl daffl merged commit 5c55db1 into feathersjs-ecosystem:master Nov 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants