This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
socket.io-client@1.7.2 breaks build 🚨 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
socket.io-client just published its new version 1.7.2.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As socket.io-client is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 228 commits .
177a65f[chore] Release 1.7.2 (#1045)766cef4[chore] Bump engine.io-client to version 1.8.2 (#1044)9dec44a[chore] Speed up lint by avoiding '**/*.js' matching pattern (#1043)8f18970[chore] Release 1.7.1 (#1037)d47bbd8[fix] Fix json import in slim build (#1036)1aa91eb[docs] Add saucelabs browser matrix in README (#1035)5ecf06a[chore] Release 1.7.0 (#1033)3d20b0f[chore] Bump engine.io-client to 1.8.1 (#1032)c1dd34c[chore] Provide a slim build without JSON3 and debug (#1030)3ba3fe3[chore] Move generated files todistfolder (#1025)fa14f91[chore] Release 1.6.0 (#1027)ed63f96[chore] Bump dependencies (#1026)1f55bf2[feature] Support minifiedsocket.io.min.js(#1021)4d1c20d[feature] emit sourcemap for socket.io.js (#953)3df7e09[chore] Release 1.5.1 (#1016)There are 228 commits in total. See the full diff.