This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
Add dist/feathers.min.js #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,8 +27,9 @@ | |||
| "clean": "rm -rf dist/ && mkdir -p dist", | |||
| "browserify:test": "browserify test/browser/test.js -t babelify --outfile dist/browser.test.js", | |||
| "browserify:dist": "browserify src/client.js -t babelify --standalone feathers --outfile dist/feathers.js", | |||
| "browserify": "npm run browserify:dist && npm run browserify:test", | |||
| "add-dist": "npm run clean && npm run browserify:dist && git add dist/ --force && git commit -am \"Updating dist\"", | |||
| "browserify:min": "browserify src/client.js -t babelify --standalone dist/ | uglifyjs > dist/feathers.min.js", | |||
There was a problem hiding this comment.
Looks like that dist/ after the --standalone needs to be feathers. 1.4.0 is broken now. 😞
There was a problem hiding this comment.
I just tried 1.4 and it seems to be working fine although the --standalone flag probably really isn't needed.
There was a problem hiding this comment.
The standalone flag makes a global of the given name. In the old version, it created window.feathers. 1.4.0 creates window.dist. I'm using rollupjs to bundle my app code, which translates external ES6 module imports into references to globals, which just broke.
There was a problem hiding this comment.
That makes sense. The export is fixed in v1.4.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64