Memory leak

[dottodot]

I pretty sure I have a really big memory leak somewhere and not sure if it's something I've done wrong or an issue in feathers.

I'm using memwatch-next and it regularly report heap growth such as

Memory leak detected:
 { growth: 512,
  reason: 'heap growth over 5 consecutive GCs (12s) - 409.2 mb/hr' }

This is resulting in the app crashing fairly regularly

Unfortunately I'm no expert working out the cause but I've found one situation where the memory just seem to keep increasing.

Below is a service for file uploading

module.exports = function(app) {
  const s3 = new AWS.S3(app.get('spaces'));

  const blobStore = S3BlobStore({
    client: s3,
    bucket: 'boxxer'
  });

  const blobService = BlobService({
    Model: blobStore
  });

  // Initialize our service with any options it requires
  app.use(
    '/upload',
    multipartMiddleware.single('file'),
    function(req, res, next) {
      req.feathers.file = req.file;
      next();
    },
    blobService
  );

  // Get our initialized service so that we can register hooks and filters
  const service = app.service('upload');

  service.hooks(hooks);
};

with the following hooks.

module.exports = {
  before: {
    all: [],
    find: [],
    get: [],
    create: [
      hook => {
        if (!hook.data.uri && hook.params.file) {
          const file = hook.params.file;
          const uri = dauria.getBase64DataURI(file.buffer, file.mimetype);
          hook.data = { uri: uri };
        }
      }
    ],
    update: [],
    patch: [],
    remove: []
  },

  after: {
    all: [],
    find: [],
    get: [],
    create: [
      hook => {
        const Image = hook.app.service('image');
        return Image.create({ key: hook.key, format: hook.format }).then(
          image => {
            hook.result = image;
            return hook;
          }
        );
      }
    ],
    update: [],
    patch: [],
    remove: []
  },
};

Using chrome inspect i taken some snapshots while doing several uploads and one thing that keeps increasing is the strings. On the screenshots attached the thing that looks strange is when you view the details on the string the seem to be a never ending nested "event created"

[dottodot]

OK I've found that leak is due to feathers-sync as removing that drastically reduces the amount of the leak

Can you move this issue or do I need to recreate

[dottodot]

feathersjs-ecosystem/feathers-sync#94

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.