Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small types and consistency style fixes. But also one real fix:
handleConnection
method ofAuthenticationBase
andJWTStrategy
was never called in response todisconnect
event, so when a jwt expiration timer emitteddisconnect
connection.authentication
was not removed and the timer was not cleared. Added listener fordisconnect
event to fix this. Also addedexpirationTimers.delete
after a timer is cleared andlt.clearTimeout
before a timer is set (to ensure that only one timer per connection exist at a time, otherwise multiple calls toreAuthenticate
with force can create more than one timer).