Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application
type parametersServiceTypes
toServices
andAppSettings
toSettings
. That's the change that does not solve anything and a breakish one (since when somebody augment a module they have to use same names). Can remove.T
toany
inService
type (and its relatives), so that you can simply writeService
instead ofService<any>
. There is some slight difference betweenService
/Service<any>
andService<any, any>
- first one hasD
asPartial<any>
. If this change comes up somewhere, there is a way to add new type later to defaultD
toany
ifT
isany
.authentication
package had a problem withlib/index.d.ts
where there was an import of@feathersjs/hooks
which is not a direct dependency of the package, fixed by tweaking exports.transport-commons
fix types forPublisher
(wrong type forcontext
arg) andApplication.channel
(not supporting an argument of typestring | string[]
).CustomMethod
type toCustomMethods
and allow to easily specifydata
and return type or keep itany
as it currently is.enableLegacyHooks
(so include custom and filter out unused ones).koa
add headers to params (not sure if should be cloned as query is, inexpress
neither query nor headers are cloned).koa
add types for feathers props on koa context -feathers
andhook
.transport-commons
andexpress
removehooks
dependency and use correct type for context - it isn't supposed to work with generic hook context, only with feathers one.