Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Use Symbol.for to instantiate shared symbols #3087

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Mar 1, 2023

This pull request ensures that all Symbols are shared from the global symbol registry so that it is possible to use different package versions.

Closes #3071

Copy link
Member

@marshallswain marshallswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@daffl daffl merged commit 7f3fc21 into dove Mar 8, 2023
@daffl daffl deleted the symbol-for-3071 branch March 8, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@feathersjs/express^5 has a reused Symbol() across pkgs, but not actually equal
2 participants