Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if javascript is disabled #911

Closed
noahmanger opened this issue Jun 4, 2015 · 5 comments
Closed

Add warning if javascript is disabled #911

noahmanger opened this issue Jun 4, 2015 · 5 comments

Comments

@noahmanger
Copy link

The datatable filters don't work without javascript. We should either have a server side fallback or just show a warning. While we're in beta I think it's fine to show a warning.

@msecret msecret self-assigned this Jun 10, 2015
@msecret
Copy link
Contributor

msecret commented Jun 10, 2015

Should this warning only appear on certain pages (such as the ones that have broken functionality)? What should the UI be for the warning?

@noahmanger
Copy link
Author

What do you think about just replicating the old IE warning we're using? It would be universal, but I think that's ok. We could keep the wording sufficiently broad, like:

Javascript Required
OpenFEC uses Javascript to provide the best possible user experience. Please enable Javascript in your browser or visit fec.gov.

@emileighoutlaw what do you think about the language?

For an example, here's what Facebook uses:

JavaScript Required
We're sorry, but Facebook doesn't work properly without JavaScript enabled. If you can't enable JavaScript try visiting the mobile-optimized website.

@jmcarp
Copy link
Contributor

jmcarp commented Jun 10, 2015

👍 to a universal warning. Lots of stuff is going to break without JS, and I don't want to deal with the overhead of updating per-page warnings when we add or remove JS from different pages.

@msecret
Copy link
Contributor

msecret commented Jun 10, 2015

@jmcarp
Copy link
Contributor

jmcarp commented Jun 12, 2015

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants