-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning if javascript is disabled #911
Comments
Should this warning only appear on certain pages (such as the ones that have broken functionality)? What should the UI be for the warning? |
What do you think about just replicating the old IE warning we're using? It would be universal, but I think that's ok. We could keep the wording sufficiently broad, like:
@emileighoutlaw what do you think about the language? For an example, here's what Facebook uses:
|
👍 to a universal warning. Lots of stuff is going to break without JS, and I don't want to deal with the overhead of updating per-page warnings when we add or remove JS from different pages. |
Merged. |
The datatable filters don't work without javascript. We should either have a server side fallback or just show a warning. While we're in beta I think it's fine to show a warning.
The text was updated successfully, but these errors were encountered: