Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Sec-FedCM-CSRF with Sec-Fetch-Dest #353

Closed
cbiesinger opened this issue Sep 27, 2022 · 2 comments
Closed

Replace Sec-FedCM-CSRF with Sec-Fetch-Dest #353

cbiesinger opened this issue Sep 27, 2022 · 2 comments
Labels
compatibility risk Issues that may lead to backwards compatibility problems

Comments

@cbiesinger
Copy link
Collaborator

Instead of introducing a new header Sec-FedCM-CSRF, I propose that we instead use the existing Sec-Fetch-Dest header with a new value web-identity, matching the root manifest's filename (.well-known/web-identity, https://fedidcg.github.io/FedCM/#check-the-root-manifest)

@bvandersloot-mozilla fyi
This was referenced Sep 27, 2022
Open
Merged
cbiesinger added a commit to cbiesinger/webappsec-csp that referenced this issue Sep 30, 2022
@cbiesinger
Add support for the webidentity destination
8752df6 
This is being added to fetch in whatwg/fetch#1495

See also issue w3c-fedid/FedCM#353 and w3c-fedid/FedCM#320
@cbiesinger cbiesinger mentioned this issue Sep 30, 2022
Merged
@samuelgoto samuelgoto added the compatibility risk Issues that may lead to backwards compatibility problems label Oct 3, 2022
mikewest pushed a commit to w3c/webappsec-csp that referenced this issue Oct 5, 2022
@cbiesinger
Add support for the webidentity destination (#567)
c8fc273 
This is being added to fetch in whatwg/fetch#1495

See also issue w3c-fedid/FedCM#353 and w3c-fedid/FedCM#320
@annevk
Copy link

annevk commented Oct 7, 2022

I hope this is now considered resolved? (Though using "webidentity" sans hyphen.)

@cbiesinger
Copy link
Collaborator Author

Yes thanks! https://fedidcg.github.io/FedCM/ does set the destination to webidentity thanks to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility risk Issues that may lead to backwards compatibility problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samuelgoto @cbiesinger @annevk