Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guardian UI: Followers should watch for Leader to kick off DKG #83

Closed
wbobeirne opened this issue Jul 17, 2023 · 2 comments
Closed

Guardian UI: Followers should watch for Leader to kick off DKG #83

wbobeirne opened this issue Jul 17, 2023 · 2 comments
Labels
bug Something isn't working guardian-ui

Comments

@wbobeirne
Copy link
Collaborator

We've run into a problem during some of our test setups that is easy to miss when you're developing solo, or setting up a 1 of 1 or 2 of 2 federation. Right now followers attempt to run DKG as soon as they approve the configuration. This is problematic if in e.g. a 2 of 3 federation, only the leader and follower 1 have joined. Follower 1 has not yet gotten any information about Follower 2 who will join shortly, so their DKG is incomplete. Once follower 2 attempts to run DKG, it'll fail because follower 1 will reject them.

We need to re-architect this so that followers go through the following flow:

  1. Follower pastes in leaders WS API URL
  2. Follower is presented with configuration from leader
  3. Follower hits approve on configuration
  4. Follower is presented with a screen that shows the status of all peers, and says that it's waiting for the leader to continue
  5. Follower sees that the leader's status has gone from SharingConfigGenParams to ReadyForConfigGen
  6. Follower transitions to the RunDKG screen and attempts to run DKG

Followers will not know how many guardians the leader intends for the federation to have, so they will not see the rows that indicate guardians that have not joined yet like the leader does.

@justinmoon
Copy link
Contributor

justinmoon commented Jul 17, 2023

As context, run_dkg just fetches the peers from the database. So at this point, the client calling this must have a full list of peers and might not currently.

If the number of peers was in the config gen params somehow, then this method could just wait until it had enough peers to try DKG.

@okjodom
Copy link
Collaborator

okjodom commented Jul 20, 2023

@justinmoon should we close this as fixed (server side) after fedimint/fedimint#2782 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working guardian-ui
Projects
None yet
Development

No branches or pull requests

3 participants