Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logs at every place that expires buildroot overrides #3060

Closed
bowlofeggs opened this issue Mar 14, 2019 · 4 comments · Fixed by #3063
Closed

Add logs at every place that expires buildroot overrides #3060

bowlofeggs opened this issue Mar 14, 2019 · 4 comments · Fixed by #3063
Assignees
@nphilipp
Labels
Buildroot Override Issues related to buildroot overrides EasyFix These are good issues to get started with if you are new to the project High priority These issues are higher priority than normal

Comments

@bowlofeggs
Copy link
Contributor

Some users have been having trouble with buildroot overrides getting unexpectedly untagged in Koji, and according to Koji the Bodhi user is the one untagging it. Unfortunately, Bodhi does not currently emit log messages when BuildrootOverride.expire() is called, so it is not easy to tell which code path is responsible for this.

We should find all the calls to BuildrootOverride.expire() and add log messages to explain why it is being called, for each one. This way we will have more useful debugging information in the future.
@bowlofeggs bowlofeggs added EasyFix These are good issues to get started with if you are new to the project Buildroot Override Issues related to buildroot overrides High priority These issues are higher priority than normal labels Mar 14, 2019
@nphilipp
Copy link
Member

I'll take a shot at this before my PTO next week.

@nphilipp
Copy link
Member

Looks like I need to be added to the org or project before I can assign this to myself.

nphilipp added a commit to nphilipp/bodhi that referenced this issue Mar 15, 2019
@nphilipp
log why buildroot overrides are expired
cbe6156 
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes fedora-infra#3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
@nphilipp nphilipp mentioned this issue Mar 15, 2019
Merged
@bowlofeggs bowlofeggs assigned bowlofeggs and unassigned bowlofeggs Mar 15, 2019
@nphilipp nphilipp self-assigned this Mar 15, 2019
bowlofeggs pushed a commit to nphilipp/bodhi that referenced this issue Mar 21, 2019
@nphilipp @bowlofeggs
log why buildroot overrides are expired
759daf4 
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes fedora-infra#3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
@bowlofeggs bowlofeggs mentioned this issue Mar 22, 2019
Closed
3 tasks
mergify bot pushed a commit that referenced this issue Mar 26, 2019
@nphilipp
log why buildroot overrides are expired
8068b62 
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes #3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
(cherry picked from commit 759daf4)
abompard pushed a commit that referenced this issue Mar 26, 2019
@nphilipp @abompard
log why buildroot overrides are expired
6fa73c4 
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes #3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
(cherry picked from commit 759daf4)
abompard pushed a commit that referenced this issue Mar 27, 2019
@nphilipp @abompard
log why buildroot overrides are expired
5a371b8 
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes #3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
(cherry picked from commit 759daf4)
@bowlofeggs
Copy link
Contributor Author

This feature is planned for inclusion in the upcoming 4.0.0 release: #3221

@bowlofeggs
Copy link
Contributor Author

Bodhi 4.0.0 beta is built and deployed to staging:

https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release
https://bodhi.stg.fedoraproject.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nphilipp nphilipp

Labels
Buildroot Override Issues related to buildroot overrides EasyFix These are good issues to get started with if you are new to the project High priority These issues are higher priority than normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log why buildroot overrides are expired nphilipp/bodhi
2 participants
@bowlofeggs @nphilipp