Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs at every place that expires buildroot overrides #3060

Closed
bowlofeggs opened this Issue Mar 14, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@bowlofeggs
Copy link
Member

bowlofeggs commented Mar 14, 2019

Some users have been having trouble with buildroot overrides getting unexpectedly untagged in Koji, and according to Koji the Bodhi user is the one untagging it. Unfortunately, Bodhi does not currently emit log messages when BuildrootOverride.expire() is called, so it is not easy to tell which code path is responsible for this.

We should find all the calls to BuildrootOverride.expire() and add log messages to explain why it is being called, for each one. This way we will have more useful debugging information in the future.

@nphilipp

This comment has been minimized.

Copy link
Collaborator

nphilipp commented Mar 15, 2019

I'll take a shot at this before my PTO next week.

@nphilipp

This comment has been minimized.

Copy link
Collaborator

nphilipp commented Mar 15, 2019

Looks like I need to be added to the org or project before I can assign this to myself.

nphilipp added a commit to nphilipp/bodhi that referenced this issue Mar 15, 2019

log why buildroot overrides are expired
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes fedora-infra#3060

Signed-off-by: Nils Philippsen <nils@redhat.com>

@bowlofeggs bowlofeggs assigned bowlofeggs and unassigned bowlofeggs Mar 15, 2019

@nphilipp nphilipp self-assigned this Mar 15, 2019

bowlofeggs added a commit to nphilipp/bodhi that referenced this issue Mar 21, 2019

log why buildroot overrides are expired
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes fedora-infra#3060

Signed-off-by: Nils Philippsen <nils@redhat.com>

@bowlofeggs bowlofeggs referenced this issue Mar 22, 2019

Closed

Release Bodhi 3.14.0 #3084

0 of 3 tasks complete

mergify bot pushed a commit that referenced this issue Mar 26, 2019

log why buildroot overrides are expired
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes #3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
(cherry picked from commit 759daf4)

abompard added a commit that referenced this issue Mar 26, 2019

log why buildroot overrides are expired
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes #3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
(cherry picked from commit 759daf4)

abompard added a commit that referenced this issue Mar 27, 2019

log why buildroot overrides are expired
This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes #3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
(cherry picked from commit 759daf4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.