Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Create/edit updates from Koji tags #3228

Merged
merged 3 commits into from
Jun 25, 2019
Merged

API: Create/edit updates from Koji tags #3228

merged 3 commits into from
Jun 25, 2019

Commits on Jun 25, 2019

  1. API: Create/edit updates from Koji tags. 

    This lets users populate builds from Koji (side-)tags when creating
updates (or repopulate when editing them). it also stores the tag in
question in Update.from_tag.

Squashed commit of the following:

commit c47e2dfbe55a2a0984ead8e1ec6a5ff6f3fee02a
Author: Nils Philippsen <nils@redhat.com>
Date:   Fri May 17 18:33:56 2019 +0200

    Move Koji tag expansion to validate_from_tag().

    This finds the latest builds in a tag in the from_tag validator and adds
    them to request.validated. This is necessary because the list of builds
    is further used in validate_acls() to decide if a user is allowed to
    submit an update for the involved builds.

    Signed-off-by: Nils Philippsen <nils@redhat.com>

commit df05cebf8aec9b3c7ca20c350ea2acef44c1e4f7
Author: Nils Philippsen <nils@redhat.com>
Date:   Tue May 14 15:24:54 2019 +0200

    Create updates from a Koji tag.

    This lets users specify a Koji tag instead of an explicit set of builds,
    from which the latest component builds will be pulled.

    Signed-off-by: Nils Philippsen <nils@redhat.com>

commit 665aa086009789da052c2721a82a795466a7ac7b
Author: Nils Philippsen <nils@redhat.com>
Date:   Tue May 14 15:22:37 2019 +0200

    Add from_tag parameter to get_updates().

    This allows testing updates where the builds should be filled from all
    latest builds in a Koji tag.

    Signed-off-by: Nils Philippsen <nils@redhat.com>

commit c84a637c70753a6bc333ba0dcb62d98a39336d58
Author: Nils Philippsen <nils@redhat.com>
Date:   Tue May 14 15:16:10 2019 +0200

    Add Update.from_tag.

    This column stores the tag from which the set of builds of an update was
    filled initially.

    Signed-off-by: Nils Philippsen <nils@redhat.com>

commit 0c0717d374f6f6bbcb51e60161576c1a389ca325
Author: Nils Philippsen <nils@redhat.com>
Date:   Tue May 14 12:22:42 2019 +0200

    Accept from_tag alternatively to builds.

    This is to let users create updates from all latest builds of a Koji
    tag.

    Signed-off-by: Nils Philippsen <nils@redhat.com>

commit d6bf4fa6b69186bee4e4b01766d47efb78220dae
Author: Nils Philippsen <nils@redhat.com>
Date:   Tue May 14 11:05:23 2019 +0200

    Add validate_builds_or_from_tag_exist().

    This validator checks that at minimum one of `builds` or `from_tag` is
    supplied as parameters and isn't empty.

    Signed-off-by: Nils Philippsen <nils@redhat.com>

commit e5e3480901cb7d9e90cb3a986c667790951e37fb
Author: Nils Philippsen <nils@redhat.com>
Date:   Tue May 14 10:58:47 2019 +0200

    Make DevBuildsys.listTagged() honor `latest` keyword.

    Previously, it could return multiple builds of the same component in a
    tag. This required updating tests which expected these wrong results.

    Signed-off-by: Nils Philippsen <nils@redhat.com>

commit 68953597b51297c7ca33ae18976018574bedec6f
Author: Nils Philippsen <nils@redhat.com>
Date:   Fri May 10 12:08:19 2019 +0200

    Add validate_from_tag().

    This validator ensures that if from_tag is supplied in the request, it
    is a valid Koji tag.

    Signed-off-by: Nils Philippsen <nils@redhat.com>

Fixes: fedora-infra#3009

Signed-off-by: Nils Philippsen <nils@redhat.com>
    @nphilipp
    nphilipp committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    5b0f9fd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into develop--update-from-sidetag-api

    @mergify
    mergify[bot] committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    3ca2ddc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into develop--update-from-sidetag-api

    @mergify
    mergify[bot] committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    eea5d90 View commit details
    Browse the repository at this point in the history