Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Querying specific buildroot overrides #4129

Merged
merged 4 commits into from
Nov 23, 2020

Conversation

karmadolkar
Copy link
Collaborator

Ref #4118
Signed-off-by: Karma Dolkar karmadolkar29@gmail.com

@karmadolkar karmadolkar requested a review from a team as a code owner September 21, 2020 07:34
@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2020

This pull request introduces 2 alerts when merging f15991d into d80e867 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2020

This pull request introduces 2 alerts when merging a21f452 into 43467b4 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Variable defined multiple times

Copy link
Contributor

@cverna cverna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing to change, then we need to add tests and also update the documentation

@@ -60,6 +60,13 @@ class Query(graphene.ObjectType):
date_approved=graphene.String(), alias=graphene.String(),
user_id=graphene.Int(), release_name=graphene.String())

resolve_getBuildrootOverrides = graphene.Field(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
resolve_getBuildrootOverrides = graphene.Field(
getBuildrootOverrides = graphene.Field(

@lgtm-com
Copy link

lgtm-com bot commented Oct 5, 2020

This pull request introduces 2 alerts when merging a270087 into 0eeea79 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Variable defined multiple times

… expirationDate, and submissionDate as arguments. Fixes fedora-infra#4118

Signed-off-by: Karma Dolkar <karmadolkar29@gmail.com>
@mergify mergify bot merged commit 805fdd0 into fedora-infra:develop Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants