Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend save_override() to set the expiration date of an override directly #4431

Merged
merged 3 commits into from
Mar 20, 2022

Conversation

abompard
Copy link
Member

The fedpkg tool needs to extend the lifetime of overrides, let's make it easier for them and add the feature here.

@abompard abompard requested a review from a team as a code owner March 17, 2022 15:39
…rectly

The fedpkg tool needs to extend the lifetime of overrides, let's make it
easier for them and add the feature here.

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Copy link
Contributor

@mattiaverga mattiaverga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a thought about adding the 'expiration_date' option to the CLI, but it doesn't seem practical, so it's just fine to add it to the bindings IMO.

@mergify mergify bot merged commit 150ed51 into fedora-infra:develop Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants