Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for frozen release state #4831

Merged
merged 4 commits into from
Nov 19, 2022

Conversation

mattiaverga
Copy link
Contributor

@mattiaverga mattiaverga commented Nov 13, 2022

The frozen release state has been available for a while, but it was never used in releng workflow. There are also many bits missing from Bodhi code to be functional. This PR will add those bits.

  • display frozen releases in release list (fixes Release freeze is not clear at all #4103 )
  • show an info pane on updates pages informing user that the release is frozen
  • allow bodhi CLI to edit a release state into frozen state
  • make bodhi-push work with frozen releases
  • force updates of frozen releases into testing before requesting them to stable

About bodhi-push, it now defaults to push stable composes for pending + current releases (just like before) and push testing composes for pending + current + frozen. This will avoid releng to stop the automatic cronjob in freeze periods (fixes #4478 ). It allows to push to stable specific updates or builds even if the release is frozen, though.

@mattiaverga mattiaverga added the WIP Work in progress label Nov 13, 2022
@mattiaverga mattiaverga requested a review from a team as a code owner November 13, 2022 16:58
@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2022

This pull request introduces 1 alert when merging 3212c7d into 85e6c48 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2022

This pull request introduces 1 alert when merging 7e73d04 into 85e6c48 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Also add a warning on updates belonging to those releases.

Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
@mattiaverga mattiaverga changed the title [WIP] Add support for frozen release state Add support for frozen release state Nov 18, 2022
@mattiaverga mattiaverga removed the WIP Work in progress label Nov 18, 2022
@mattiaverga mattiaverga merged commit b89b437 into fedora-infra:develop Nov 19, 2022
@mattiaverga mattiaverga deleted the freeze branch November 19, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate bodhi pushes in releng freezes Release freeze is not clear at all
1 participant