Make the websocket configurable. #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was hardcoded to phone home to Fedora Infra's infrastructure, but SDub noticed that his private instance was also phoning home. We should let others disable that or point it at their own websocket server.
| @@ -83,7 +83,14 @@ | |||
| <script src="{{ url_for('static', filename='jquery-2.1.0.min.js') }}"></script> | |||
| {% if autoscroll %} | |||
| <script src="{{ url_for('static', filename='autoscroll.js') }}"></script> | |||
| {% if websocket_address is defined %} | |||
There was a problem hiding this comment.
Do we really want the is defined part? If the variable is not set, or is null, jinja will treat it in the same way.
|
1 comment, otherwise 👍 |
|
Thanks @pypingou. I could go either way with the |
ralphbean
added a commit
that referenced
this pull request
Jun 1, 2015
Make the websocket configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was hardcoded to phone home to Fedora Infra's infrastructure, but
SDub noticed that his private instance was also phoning home. We should
let others disable that or point it at their own websocket server.