Scrub args from keywords before initializing. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is wild. The symptom you'd get is this: The *first* time ``fedmsg.publish(topic=topic, msg=dict(...))`` is ever called, fedmsg isn't initialized yet. Those topic and msg arguments are passed through to ``init(**kw)`` as extra keyword arguments and so "topic" and "msg" appear in the global config dict (internally). This never mattered in practice. They were there, and noone cared. I'm hitting it now because in fmn, we try to call ``fedmsg.meta.msg2link(msg=msg, **config)`` but there is a ``msg`` key in config from the first time ``publish`` was called and so it fails with "cannot have two keyword arguments named 'msg'".
|
|
||
| for arg in scrub: | ||
| if arg in kw: | ||
| del kw[arg] |
There was a problem hiding this comment.
Would we want to log which arg are dropped?
There was a problem hiding this comment.
Heh, I don't think logger isn't set up at this point. It would need its config which hasn't been loaded yet.
|
After some discussions and thoughts on IRC, 👍 for me |
ralphbean
added a commit
that referenced
this pull request
Feb 19, 2015
Scrub args from keywords before initializing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is wild.
The symptom you'd get is this: The first time
fedmsg.publish(topic=topic, msg=dict(...))is ever called, fedmsgisn't initialized yet. Those topic and msg arguments are passed through
to
init(**kw)as extra keyword arguments and so "topic" and "msg"appear in the global config dict (internally).
This never mattered in practice. They were there, and noone cared.
I'm hitting it now because in fmn, we try to call
fedmsg.meta.msg2link(msg=msg, **config)but there is amsgkeyin config from the first time
publishwas called and so it failswith "cannot have two keyword arguments named 'msg'".