Remove artifical keys from datagrepper backlog to pass validation. #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, when fedmsg-hub starts up, it tries to read in its backlog of messages from datagrepper in case it missed anything. It successfully gets the list, but then every single one of the messages fails validation. There's a gist here that demonstrates what needs to happen to make this work: https://gist.github.com/ralphbean/b532ad3bc4a8333fa03d4e4e48451885 There are two changes required. This one here, in fedmsg, and another in fedora-infra/datanommer#87.
|
👍 for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, when fedmsg-hub starts up, it tries to read in its backlog of
messages from datagrepper in case it missed anything. It successfully
gets the list, but then every single one of the messages fails
validation.
There's a gist here that demonstrates what needs to happen to make this
work: https://gist.github.com/ralphbean/b532ad3bc4a8333fa03d4e4e48451885
There are two changes required. This one here, in fedmsg, and another in
fedora-infra/datanommer#87.