Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

Fix #96 "in advance of" should read "newer than" #299

Merged
merged 2 commits into from
Jul 27, 2015
Merged

Fix #96 "in advance of" should read "newer than" #299

merged 2 commits into from
Jul 27, 2015

Conversation

vhalli
Copy link

@vhalli vhalli commented Jul 25, 2015

No description provided.

@pypingou
Copy link
Member

👍 for the change but I expect this will require an adjustment to the unit-test suite as well :)

@inheritedburrp
Copy link
Contributor

@pypingou yes working on it.

@inheritedburrp
Copy link
Contributor

it seems that the build is failing for some other reason.

@pypingou
Copy link
Member

I'm a little confused here, @vhalli opened the pull-request but with the commits from @inheritedburrp ?

@inheritedburrp
Copy link
Contributor

We had dev Sprint, and I had some issues with my laptop. Is the PR all ok?

@pypingou
Copy link
Member

On Sun, Jul 26, 2015 at 10:09:11AM -0700, Anuj Sharma wrote:

We had dev Sprint, and I had some issues with my laptop. Is the PR all ok?

Code wise it looks fine, I just wanted to test it locally before merging and see
if I could reproduce/fix the issue seen on travis.
I'll let you know once I did this (which might be on Tuesday, unless someone
beats me to it)

ralphbean added a commit that referenced this pull request Jul 27, 2015
This should fix the bug introduced in #295 that @vhalli and @inheritedburrp hit in #299.
@ralphbean
Copy link
Contributor

Looks good here. :) Thanks!

ralphbean added a commit that referenced this pull request Jul 27, 2015
Fix #96  "in advance of" should read "newer than"
@ralphbean ralphbean merged commit 6d5f2f8 into fedora-infra:develop Jul 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants