Fix delete #92
Merged
Fix delete #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for full day meeting
…s the form validation
…deleting recursive meetings
This field is in fact only set by a GET parameter
…url if any is provided
Find the meeting date closest to the date specified, it is either the date specified or the next occurence, use this as reference date. - If all the meeting is specified: kill the recursivity one day before the next iteration. - If all the meeting is false: kill the recursivity one day before the next iteration, copy the old meeting into a new one, this new meeting starts at the next iteration, so <frequency> days after the date found ealier and ends at the original recursion end. Fixes https://fedorahosted.org/fedocal/ticket/101
- forward the form_date argument up to delete_meeting - call appropriately the delete_recursive_meeting function from the internal API
…e representation of it
…full day meetings...
| days=meeting.recursion_frequency) | ||
| new_meeting.recursion_ends = original_rec_end | ||
|
|
||
| new_meeting.save(session) |
There was a problem hiding this comment.
Is this missing a session.commit()?
There was a problem hiding this comment.
it's in the controller (for some reasons :/)
|
👍 to merge! 🏩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.