Openidc #188
Merged
Openidc #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremycline
reviewed
Dec 22, 2016
fedora/client/openidcclient.py
Outdated
| data={'client_id': self.client_id, | ||
| 'client_secret': self.client_secret, | ||
| 'token': token['access_token']}) | ||
| # TODO: Be a bit more stable in handling if we get a non-JSON object |
There was a problem hiding this comment.
I know this is a work-in-progress that you haven't tested and kindly opened for me, but here's some drive-by feedback
I'd recommend doing something like
# Throw an HTTPError-based exception for a HTTP 400+ code
resp.raise_for_status()
try:
return resp.json()
except JSONDecodeError:
raise SomeExceptionThatTellsUsersTheServerShouldHaveGivenUsJSON
There was a problem hiding this comment.
I like @jeremycline's suggestion 👍
|
Just FYI, module-build-service is blocking on this PR over here: https://pagure.io/fm-orchestrator/issue/268 |
fedora/client/openidcclient.py
Outdated
| @@ -0,0 +1,385 @@ | |||
| #!/usr/bin/env python2 -tt | |||
There was a problem hiding this comment.
bad idea to have shebangs (especially python2's ;))
testopenidc.py
Outdated
|
|
||
| inst = OpenIDCBaseClient('http://myapp.com', 'myapp', id_provider='http://172.17.0.2:8080/openidc/') | ||
|
|
||
| print inst.get_token(['ipsilon'], False) |
There was a problem hiding this comment.
shouldn't it be print functions?
fedora/client/openidcclient.py
Outdated
|
|
||
| # Just return a message | ||
| out = StringIO() | ||
| print >>out, "You can close this window and return to the CLI" |
fedora/client/openidcclient.py
Outdated
| query['redirect_uri'] = return_uri | ||
| query['state'] = 'ignored' | ||
| query['response_mode'] = 'query' | ||
| query = urllib.urlencode(query) |
There was a problem hiding this comment.
not gonna work on py3.. it's in urllib.parse there. you can use six.moves to get urllib_parse
puiterwijk
force-pushed
the
openidc
branch
2 times, most recently
from
f8e5b57
to
fbdb27b
Compare
|
LGTM 👍 |
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.