Try to implement clientside API for otps that is both backwards compatible and has the ability to be efficient. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compatible and has the ability to be efficient.
| invalid, the server will return a 403 http response code to indicate an error. | ||
| If the API receives a 403 from sending the username and password, it will then | ||
| try sending a ``session_id`` if it has given one. If the API receives a 403 | ||
| from this as well, thenit will translate this into a |
There was a problem hiding this comment.
Missing space "thenit"
I'd suggest changing the "translate this into a..." into "will throw"
| ``session_id`` for the logged in user. If one or both of the pieces are | ||
| invalid, the server will return a 403 http response code to indicate an error. | ||
| If the API receives a 403 from sending the username and password, it will then | ||
| try sending a ``session_id`` if it has given one. If the API receives a 403 |
There was a problem hiding this comment.
grammar here is not quite right and I'm not sure how it should be. "if it has given one"... should that be "if it has one"?
|
Looks generally quite nice, looking forward to test it a little on stg :) |
|
At flock 2014 we decided to close this. We're starting to think that BaseClient is legacy and that OpenId BaseClient is the wave of the future. So we're going to ignore the question of handling otp in BaseClient and figure out how to add it to OpenIdBaseClient instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big patch and a pretty big change. Take a look and make as many comments as you feel like. I can add more comments, improve the documentation, or whatever you feel is needed.