Fix #113 Text in bugzilla has to be clear. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Hracek <phracek@redhat.com>
|
👍 here |
ralphbean
added a commit
that referenced
this pull request
Mar 15, 2016
Fix #113 Text in bugzilla has to be clear.
| @@ -284,8 +284,7 @@ def _handle_anitya_update(self, upstream, package, msg): | |||
| else: | |||
| self.new_triggered_task_ids[task_id] = [bz, None, str(upstream), str(package)] | |||
| else: | |||
| note = 'Patching or scratch build for %s and version %s FAILED.\n' \ | |||
| 'See for details' % (package, version) | |||
| note = 'Patching or scratch build for %s and version %s FAILED.\n' % (package, version) | |||
There was a problem hiding this comment.
Sorry but to me this English sentence is really difficult to understand. I will only like to suggest drop "and version" words from above. Also, we in general always write or say
"name-version" together and not separately.
There was a problem hiding this comment.
True there. So something instead like:
Patching or scratch build for %s-%s failed." % (...
I'll go ahead and commit that directly to the develop branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petr Hracek phracek@redhat.com