Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to rewrite tests in example project to unittest #9

Closed
frenzymadness opened this issue Jan 12, 2018 · 5 comments
Closed

Consider to rewrite tests in example project to unittest #9

frenzymadness opened this issue Jan 12, 2018 · 5 comments

Comments

@frenzymadness
Copy link
Member

Because there seem to be some incompatibilities between attrs module (pytest dependency) and Jython, it might make sense to rewrite tests to use the unittest module instead of pytest.

pytest-dev/pytest#3111
python-attrs/attrs#321

@nicoddemus
Copy link

Alternatively you might pin pytest to 3.2 which does not require attrs (dependency to attrs was introduced in 3.3), at least until the attrs issue with Jython is sorted out.

@hroncok
Copy link
Member

hroncok commented Jan 12, 2018

That sounds like a good workaround for now.

@frenzymadness
Copy link
Member Author

Thanks @nicoddemus! Workaround implemented in 1db9436

@nicoddemus
Copy link

I suppose this can be closed now that 1db9436 is on master?

@frenzymadness
Copy link
Member Author

Yes, sure. Closing…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants