-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to reproduce the DLPFC analysis results #13
Comments
We have updated the file https://github.com/feiyoung/PRECAST_Analysis/blob/main/Real_data_analysis/dorsolateral_prefrontal_cortex.R. Now user can run the code locally and the required data will be downloaded automatically. We have run the code again and produce the results of ARIs as follows: |
Thanks a lot! I've successfully reproduced the results! |
Sorry to bother you again. Is there any fundamental difference in principle between code in the tutorial and in the GitHub PRECAST_Analysis package? While I can achieve relatively better results using the SPARK results and the code from the GitHub PRECAST_Analysis package, the results are not favorable (median ARI = 0.37) when I extract the top 2000 genes list based on the SPARK results with the code provided by PRECAST_Analysis and use The complete code is as follows:
Why is this happening? |
All the high-level functions |
Thank you for your response. I will try as you suggested! |
Hello, I tried setting |
We will check why this happened. Thank you for your feedback! |
OK, thanks! |
Hi, you can try this setting: |
Thank you! I've got it! |
Hi,
The ARI reported have high values. If I add the genelist identified with your code, the values drop considerevoly
In addition, I noted a problem of aggressive correction. In the second subject (slides 151669, 151670, 151671, 151672), the grey matter is clusterized together the Layer 6. Is there a parameter setting to avoid aggressive clustering? |
Prior to the development of this package, we relied on a set of low-level functions to execute operations on the genelist. The reproducible code that demonstrates this process is available at: In addressing the issue where grey matter clusters together with Layer 6, you may consider increasing the number of clusters to achieve a more accurate segregation. |
Hi,
Thank you for this great work!
While attempting to reproduce your DLPFC results, I encountered an issue. The code provided at https://feiyoung.github.io/PRECAST/articles/PRECAST.DLPFC.html includes code only for single-sample analysis. The code available at https://github.com/feiyoung/PRECAST_Analysis/blob/main/Real_data_analysis/dorsolateral_prefrontal_cortex.R is not encapsulated and lacks input files of the result of SPARK method.
I conducted a joint analysis of 12 DLPFC data slices, adhering to the example code and parameters from the Human Breast Cancer Data Analysis. I adjusted parameters including
selectGenesMethod
,gene.number
,postmin.spots
(set to 1 or 15), andpostmin.features
(set to 10 or 15). However, the resulting ARI is significantly low and inconsistent with Figure 2.c and Figure S21.d.Here are the results with postmin.spots = 15, postmin.features = 15, and gene.number = 2000:
For selectGenesMethod = "SPARK-X":
For selectGenesMethod = "HVGs":
Could you kindly share the code used to generate the results in Figure 2?
The text was updated successfully, but these errors were encountered: