GPLv3 Compatibility?

[marcio-ao]

Hello,

We would like to incorporate the code from the USB Host Shield in the Marlin firmware for 3D printers as this would allow printers to read USB Flash Drives rather the SD cards. The company I work for is a great believer in open-source and we would donate all our integration work to the open-source and 3D printing community.

However, I notice that the USB Host Shield is released under "GPL v2" rather than "GPLv2 or later", which would preclude integration with Marlin, which is released under the "GPL v3".

Is there any chance the license could be upgraded to either the GPL v3, or to include the wording "GPLv2 or later" in order to maintain compatibility with the GPL v3?

Information why this is necessary for the GPLv3 and GPLv2 is listed here:

https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility

Thank you!

-- Marcio

[felis]

I like Lulzbot and I like my TAZ 6 :-), the whole product documentation for which is open sourced and available.

@Lauszus , @xxxajk - do you have objections to changing the wording of the license to 'GPLv2 or later'?

[Lauszus]

I'm in for changing the license as well. I have a few 3D printers running Marlin, so I'm excited to see what they come up with :)

[xxxajk]

I've no problem with GPL2 or later...

[marcio-ao]

This is fantastic news! Another engineer and I have already done preliminary work on this and we know that we can reuse the FAT routines that Marlin already has for SD cards, so we only need the following files that implement the block-level USB mass storage access:

• address.h
• avrpin.h
• confdescparser.h
• macros.h
• masstorage.cpp
• masstorage.h
• max3421e.h
• message.cpp
• message.h
• parsetools.cpp
• parsetools.h
• printhex.h
• settings.h
• Usb.cpp
• Usb.h
• usb_ch9.h
• UsbCore.h
• usbhost.h

So for our purposes, if just those particular files were updated with the wording "GPL v2 or later", we would be able to perform the integration.

Thank you so much!

-- Marcio

[marcio-ao]

I just wanted to share some preliminary results. This is actually Marlin reading files from a USB drive. It is also driving a color LCD touch panel (another project we have been working on):

Printing already works, although the only glitch is that currently the drive insertion/removal is not recognized (we still haven't figured out how to detect those events)

[xxxajk]

Very cool. Thanks for sharing!

…

On Mar 19, 2018 11:43 AM, "Marcio Teixeira" ***@***.***> wrote: I just wanted to share some preliminary results. This is actually Marlin reading files from a USB drive. It is also driving a color LCD touch panel (another project we have been working on): [image: marlinusb] <https://user-images.githubusercontent.com/29129419/37605915-e30ff9d6-2b59-11e8-978d-47302ceb6044.JPG> Printing already works, although the only glitch is that currently the drive insertion/removal is not recognized. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#364 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADskzDSeVvBNJCLHKGbZMNLvnj4wDiwBks5tf9IggaJpZM4SpQPX> .

[marcio-ao]

Curious whether there will be a commit with the files with an updated license? This is not something I feel comfortable doing myself on just our sources. I would like to replace the files I am currently using with something with the correct licenses that matches what is in this repo.

I suppose I could also try using USB Host Shield 3.0, if you guys feel that is a better choice and are willing to re-license that as well.

[Lauszus]

Since @felis assigned himself, I was assuming that he would do it?

[marcio-ao]

Anything happening with this?

[Lauszus]

@marcio-ao I have updated the copyright header in the relevant files in 00aa355.

[marcio-ao]

@Lauszus : Awesome! Thank you so much!

[Lauszus]

You're welcome :)

[marcio-ao]

@Lauszus : Sorry to bother you again, is there a chance you could update the license for the following files as well?

• version_helper.h
• hex_dump.h
• sink_parser.h

I'm sorry I didn't request this sooner. I got caught up in a new printer releases and I had to put this on hold for a while.

[Lauszus]

@marcio-ao sorry for the late reply, it was fixed in: 06d5ed1.

[marcio-ao]

@Lauszus : Thank you! I was able to roll it all up as a PR to Marlin (#11115). Hopefully we will see this new feature standard in Marlin 2.0. I appreciate all the help along the way! :)

[Lauszus]

Great! Looking forward to seeing the code in the wild :)