-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support shells other than bash #3
Comments
Yeah sure, but the actual code run with |
It doesn't work with fish because you set an environment variable temporarily using the syntax "VAR=foo command". zsh is largely compatible with bash, but fish isn't, and that syntax doesn't work. I think it's simpler to invoke "bash -c" than to worry about configuring travis to run your code through multiple shells, but you're the boss. =) |
FWIW, here's the error from fish, scrubbed of the info about the particular commit:
|
I took an initial stab at this (60aa142). The problem is that the input to |
@sethfowler I installed fish and with the last two commits it appears to be working. Can you confirm? |
I'm gonna close this. You can re-open if it still breaks for you |
The git rebase
exec
command runs with the user's default shell. git-fiddle uses bash syntax, so it'd probably be wise to explicitly invoke bash. Otherwise, git-fiddle won't work for people who use, for example, the fish shell.The text was updated successfully, but these errors were encountered: