-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ros2_easy_test #41661
Add ros2_easy_test #41661
Conversation
ros2_easy_test: | ||
doc: | ||
type: git | ||
url: https://github.com/felixdivo/ros2-easy-test.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually wanted to add https://ros2-easy-test.readthedocs.io here, but I think only type: git
is supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Timple yes, this registry is specifically for build farm generated docs with rosdoc2 (for ROS 2) and the most supported case is using the source repository as the documentation source, generating and uploading docs to docs.ros.org.
I genuinely thought that there was a "documentation" type for <url>
s in package.xml but it's not in https://www.ros.org/reps/rep-0149.html#url-multiple, if you set your readthedocs site as the project website it will be linked as the project website on index.ros.org and you can link it from the generated API docs / project readme as well which should help direct people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll solve that in the package.xml then. But that's not a blocker for this PR right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is merged into main
thanks to @Timple's felixdivo/ros2-easy-test#47
@Timple There is now a version 0.3.0. |
Great, that's what we'll use for the binaries after this PR is approved/merged |
I did not find any documentation on how to make new releases (e.g., via git tags, by package.xml, etc.; and if this is scraped automatically). Is this the right process? |
Step one is getting this PR merged. That's kind of like the approval for the package and package name. |
Holding for an upcoming Rolling sync. |
Package name details$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
<name>ros2_easy_test</name>
License details$ find . -name "package.xml" -exec grep --color=auto -e "<license>" "{}" "+"
<license>MIT</license> |
Please Add This Package to be indexed in the rosdistro.
rolling
The source is here:
https://github.com/felixdivo/ros2-easy-test
Checks
Notes
Replaces #39892
@felixdivo you marked it help-wanted so I'd gave it a shot here.