Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ros2_easy_test #41661

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add ros2_easy_test #41661

merged 1 commit into from
Jul 17, 2024

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Jun 17, 2024

Please Add This Package to be indexed in the rosdistro.

rolling

The source is here:

https://github.com/felixdivo/ros2-easy-test

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

Notes

Replaces #39892

@felixdivo you marked it help-wanted so I'd gave it a shot here.

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Jun 17, 2024
ros2_easy_test:
doc:
type: git
url: https://github.com/felixdivo/ros2-easy-test.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually wanted to add https://ros2-easy-test.readthedocs.io here, but I think only type: git is supported?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Timple yes, this registry is specifically for build farm generated docs with rosdoc2 (for ROS 2) and the most supported case is using the source repository as the documentation source, generating and uploading docs to docs.ros.org.

I genuinely thought that there was a "documentation" type for <url>s in package.xml but it's not in https://www.ros.org/reps/rep-0149.html#url-multiple, if you set your readthedocs site as the project website it will be linked as the project website on index.ros.org and you can link it from the generated API docs / project readme as well which should help direct people.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll solve that in the package.xml then. But that's not a blocker for this PR right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is merged into main thanks to @Timple's felixdivo/ros2-easy-test#47

@felixdivo
Copy link
Contributor

@Timple There is now a version 0.3.0.

@Timple
Copy link
Contributor Author

Timple commented Jun 19, 2024

@Timple There is now a version 0.3.0.

Great, that's what we'll use for the binaries after this PR is approved/merged

@felixdivo
Copy link
Contributor

I did not find any documentation on how to make new releases (e.g., via git tags, by package.xml, etc.; and if this is scraped automatically). Is this the right process?

@Timple
Copy link
Contributor Author

Timple commented Jul 4, 2024

Step one is getting this PR merged. That's kind of like the approval for the package and package name.

@marcoag
Copy link
Contributor

marcoag commented Jul 10, 2024

Holding for an upcoming Rolling sync.

@marcoag marcoag added the held for sync Issue/PR has been held because the distribution is in a sync hold label Jul 10, 2024
@marcoag
Copy link
Contributor

marcoag commented Jul 16, 2024

  • At least one of the following must be present
    • Top level license file:
    • Per package license files:
  • License is OSI-approved: MIT
  • License correctly listed in package.xmls
  • Public source repo: https://github.com/felixdivo/ros2-easy-test
  • Source repository contains ROS packages
  • Each package meets REP-144 naming conventions
Package name details
$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
<name>ros2_easy_test</name>
License details
$ find . -name "package.xml" -exec grep --color=auto -e "<license>" "{}" "+"
<license>MIT</license>

@marcoag marcoag removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Jul 16, 2024
@marcoag marcoag merged commit ec53ec2 into ros:master Jul 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants