Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped buttons #16

Open
matteoferigo opened this issue Oct 23, 2017 · 14 comments
Open

Grouped buttons #16

matteoferigo opened this issue Oct 23, 2017 · 14 comments

Comments

@matteoferigo
Copy link

Hi, I saw that there is a type option named group, but I can't see any documentation about that.
How can I implement them?

Thanks

@rawnly
Copy link

rawnly commented Oct 23, 2017

I think that is the same as the electron touchbar documentation

@matteoferigo
Copy link
Author

I think so, but the result is just a list of single buttons (not grouped).

{
  "type": "group",
  "elements": [{
    "name": "add-file",
    "type": "button",
    "label": "Add file",
    "command": "tree-view:add-file"
  }, {
    "name": "add-folder",
    "type": "button",
    "label": "Add folder",
    "command": "tree-view:add-folder"
    }]
}

@rawnly
Copy link

rawnly commented Oct 24, 2017

Yes, I think that the "group" as you mean is not supported by Electron Touchbar API

@felixerdy
Copy link
Owner

Maybe you are looking for a Segmented Control? This function is currently not included in this package...

@rawnly
Copy link

rawnly commented Oct 25, 2017

Maybe you are looking for a Segmented Control? This function is currently not included in this package...

I don't think so, this is the segment control:
touch bar shot 2017-10-25 at 15 20 30

and I think he means something like this:

Group label

touch bar shot 2017-10-25 at 15 22 50

Group Items

touch bar shot 2017-10-25 at 15 22 52

The screenshots above are from Better Touch Tool

@matteoferigo
Copy link
Author

Whoops! I meant the segment control, just to group a set of buttons.
Is it planned to be released in a next release?

@felixerdy
Copy link
Owner

felixerdy commented Oct 25, 2017

I will take a look at that but can not promise anything. What kind of functions do you want to do with them? @matteoferigo

@rawnly
Copy link

rawnly commented Oct 25, 2017

Ah okay, he could use the Popover which is kind of similar

Yes I think so, I'm testing them all and it's seems to be the right one!

@rawnly
Copy link

rawnly commented Oct 25, 2017

@felixerdy it's could be cool to have an extra file to edit, with all the touchbar items instead the settings textarea.

It could be more productive, and support syntax highlighting, linters etc..

Just a simple javascript module

  module.exports = [
  //  ...components
]

@matteoferigo
Copy link
Author

@felixerdy I would like to group some buttons to get a quicker accessibility
Example: [Add file|Add folder] [Beautify]

@idoo
Copy link

idoo commented Feb 22, 2018

any news?

@felixerdy
Copy link
Owner

Sorry, I still had no time to work on that. PRs are welcome!

@matteoferigo
Copy link
Author

matteoferigo commented Dec 28, 2018

I created a PR to introduce touch bar segmented control
Unfortunately, this will not close this issue, because the aspected behavior is a group of buttons.
What segmented control does is simply to show a bunch of selectable segments, which have few options, nothing comparable with buttons
Still dreaming on…

@thirstyice
Copy link

See my PR #46
I think it does what you need to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants