Fix application ID name

[jameshfisher]

There's a lot of terminological/conceptual confusion in the current API. An .appx file should have an AppXManifest.xml which looks like the following, omitting unimportant elements:

<?xml version="1.0" encoding="utf-8"?>
<Package ...>
    <Identity Name="12345MyCompany.MyApp" ... />
    ...
    <Applications>
        <Application Id="MyApp" ...>
            ...
        </Application>
    </Applications>
</Package>

Notice that there are two separate identities: the Package Name, and the Application Id.

When you run electron-windows-store, it generates an AppXManifest.xml from the config you supply. The template is here and it looks like:

<?xml version="1.0" encoding="utf-8"?>
<Package ...>
  <Identity Name="${identityName}" ... />
  ...
  <Applications>
    <Application Id="${packageName}" ...>
      ...
    </Application>
  </Applications>
</Package>

Notice in the variable names: it calls the package name identityName, and calls the application id packageName. These template variables are subtituted by the user-supplied config like so:

lib/convert.js:      result = result.replace(/\${identityName}/g, program.identityName || program.packageName)
lib/convert.js:      result = result.replace(/\${packageName}/g, program.packageName)

This means, to create a correct AppXManifest.xml, you need to call it like so:

const convertToWindowsStore = require('electron-windows-store');
convertToWindowsStore({
    identityName: '12345MyCompany.Ghost',  // This is actually the package name!
    packageName: 'Ghost',  // This is actually the application id!!
    // ...
});

This is very confusing, and has led to many tickets:

• Invalid manifest generated when the package name starts with a number #82
• Pre-appx AppXManifest.xml has validation error #114
• MakeAppx fails with certificate issued to name with comma #103
• Microsoft provides an identity name and family name that the program won't accept #120

The best way forward would be to introduce a separate program.applicationId config, which is used in preference to the packageName.

Additionally, this PR deprecates the identityName, because the best name is just packageName, as this is the established terminology.

[jameshfisher]

Note for comparison this alternative project which has the API I suggest in the PR: https://www.electron.build/configuration/appx

[mahnunchik]

Any news?

[jameshfisher]

@mahnunchik no, I think this repo is dead/unmaintained :-(