Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing ConPty terminal session with constant active console output randomly blocks AppService to send messages between UWP and SystemTray. #722

Closed
maxhora opened this issue Apr 14, 2020 · 1 comment · Fixed by #733
Labels
bug Something isn't working

Comments

@maxhora
Copy link
Collaborator

maxhora commented Apr 14, 2020

Repro steps:

  • Open five or more cmd.exe sessions and run dir /s to list recursively all files in directory with huge amount of files.
  • Start closing sessions one be one and check that Fluent can accept new user input after closing of each session.
  • Issue: Closing of tab with active console output printing causes blocking AppService to send and receive any messages between UWP and SystemTray.

Before the recent change https://github.com/felixse/FluentTerminal/pull/715/files#diff-8d54eec5b0b0d0a282e25b2f632658d4R25 sending of messages between UWP and SystemTray was blocked during all 100% tries to close the terminal session with active console output.

cc: @mjs @felixse

@maxhora maxhora added the bug Something isn't working label Apr 14, 2020
@maxhora maxhora changed the title Closing ConPty terminal session with constant active console output randomly blocks AppService to send messaged between UWP and SystemTray. Closing ConPty terminal session with constant active console output randomly blocks AppService to send messages between UWP and SystemTray. Apr 14, 2020
@maxhora
Copy link
Collaborator Author

maxhora commented Apr 18, 2020

It seems call of ClosePseudoConsole causes hanging behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant