Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xterm.js as Git Submodule #4

Closed
x1unix opened this issue Feb 2, 2018 · 4 comments
Closed

Use xterm.js as Git Submodule #4

x1unix opened this issue Feb 2, 2018 · 4 comments

Comments

@x1unix
Copy link

x1unix commented Feb 2, 2018

I recommend to use xterm.js component (and also rest of the components such as Client as Git submodules.

This allows to work and update the components independently and also improves code organization.

Good luck!

@felixse
Copy link
Owner

felixse commented Feb 2, 2018

Hi,
yeah I know putting a patched xterm.js in there is a bit crappy, but I will be able to remove it once xterm.js 3.1.0 will be released (planned for next week). As for the rest of the components: They are all pretty tightly coupled, so I don't think there is a need for updating them separately. Nevertheless thank you for your suggestions 👍

@x1unix
Copy link
Author

x1unix commented Feb 2, 2018

@felixse, thank you for the feedback! Do you know the way how can Win32 apps use UWP UI? Afaik UWP doesn't have access to win32 and can't start processes ( except the url handlers) so thats the reason why you use nodejs workaround, but the explorer is regular win32 app but it utilizes UWP components.

@x1unix x1unix closed this as completed Feb 2, 2018
@manuelelucchi
Copy link

@x1unix since redstone 4 you can use windows.Ui.composition on win32 programs and with rs5 you should use also windows.ui.xaml. But nothing more for now. The best solution is an uwp that calls win32 (there is a large subset of win32 api that can be called from uwp)

@felixse
Copy link
Owner

felixse commented Feb 2, 2018

Yes, the only thing we can do with the current state of UWP is using FullTrustProcessLauncher to start a win32 program and then rely on IPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants