Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SendExpectXXX commands public #48

Open
GoogleCodeExporter opened this issue Aug 27, 2015 · 2 comments
Open

Make SendExpectXXX commands public #48

GoogleCodeExporter opened this issue Aug 27, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

Some redis commands don't seem to be supported by the current RedisClient 
implementation (e.g. CONFIG). It would be great if all the SendCommand methods 
would be public, so that anybody is able to send new/unsupported commands.

Especially for the CONFIG command it would be nice to have an accessor like 
this:

client.Configuration["save"] = "900 1 300 10 60 1000";

Or even typed access like this:

client.Configuration.Save = new []
{
    new SaveConfigurationSetting(900, 1),
    new SaveConfigurationSetting(300, 10),
    new SaveConfigurationSetting(60, 1000),
};

Original issue reported on code.google.com by daniel.k...@googlemail.com on 21 Nov 2010 at 12:44

@GoogleCodeExporter
Copy link
Author

Yeah I'm not a big fan of exposing internal methods, it inhibits re-factoring 
and would simply prefer to receive a patch for any unimplemented commands so 
all users end up benefiting rather than them maintaining their own custom 
implementations.

I think initially I prefer something like:
client.ServerConfig["save"] = "900 1 300 10 60 1000";

For greater simplicity and flexibility.

- Demis

Original comment by demis.be...@gmail.com on 21 Nov 2010 at 5:14

@GoogleCodeExporter
Copy link
Author

Yes, I thought about "ServerConfig" instead of "Configuration", but there's 
also the property "Info" that actually exposes server information, so I 
prefered "Configuration".

However, for now the CONFIG command is the only one I miss. It would be great 
to see it in the next release.

Original comment by daniel.k...@googlemail.com on 21 Nov 2010 at 11:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant