Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTG JSON 4 support #21

Closed
fenhl opened this issue Feb 21, 2019 · 1 comment
Closed

MTG JSON 4 support #21

fenhl opened this issue Feb 21, 2019 · 1 comment
Assignees
@fenhl
Labels
bug help wanted

Comments

@fenhl
Copy link
Owner

fenhl commented Feb 21, 2019 •
edited
Loading

The script currently fails because of the breaking changes in MTG JSON version 4. I see two feasible ways of fixing this:

  1. Update the mtgjson dependency with Update for MTG JSON 4 mbr/pymtgjson#7 or replace it.
  2. Rewrite the script in Rust, which is planned anyway for integration with the Lore Seeker desktop app.

I'm probably going to go ahead with option 2, but a pull request with option 1 would be welcome. Update: work on option 2 is in progress on the riir branch.
@fenhl fenhl self-assigned this Feb 21, 2019
@fenhl fenhl pinned this issue Sep 25, 2019
@fenhl fenhl mentioned this issue Jan 22, 2020
Closed
@fenhl fenhl mentioned this issue Nov 20, 2020
Open
6 tasks
@fenhl
Copy link
Owner Author

fenhl commented Nov 20, 2020

Since this has seen a lot of progress already, I'm closing this in favor of #25.

@fenhl fenhl closed this as completed Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fenhl fenhl

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fenhl