Restructure cell orientation information passed into tabulate_tensor and transform_reference_basis_derivatives

[mscroggs]

Currently, edge_reflections, face_rotations and face_reflections are passed in, as well as quadrature_permutation in tabulate_tensor.

ffcx/ffcx/codegeneration/ufc.h

Lines 442 to 447 in 88a5318

	typedef void(ufc_tabulate_tensor)(
	ufc_scalar_t* restrict A, const ufc_scalar_t* w, const ufc_scalar_t* c,
	const double* restrict coordinate_dofs, const int* entity_local_index,
	const uint8_t* restrict quadrature_permutation,
	const bool* edge_reflections, const bool* face_reflections,
	const uint8_t* face_rotations);

ffcx/ffcx/codegeneration/ufc.h

Lines 135 to 140 in 88a5318

	int (*transform_reference_basis_derivatives)(
	double* restrict values, int order, int num_points,
	const double* restrict reference_values, const double* restrict X,
	const double* restrict J, const double* restrict detJ,
	const double* restrict K, const bool* edge_reflections,
	const bool* face_reflections, const uint8_t* face_rotations);

This information should be passed in a more tidy way, possibly as an array cell_ordering[dimension][rotation/reflection][entiity_index].