Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign FE interpolation (and get it working again for multi-point dofs) #33

Closed
blechta opened this issue Jun 8, 2018 · 1 comment · Fixed by #296
Closed

Redesign FE interpolation (and get it working again for multi-point dofs) #33

blechta opened this issue Jun 8, 2018 · 1 comment · Fixed by #296
Labels
bug Something isn't working enhancement New feature or request

Comments

@blechta
Copy link
Member

blechta commented Jun 8, 2018

Original evaluate_dof(s) using ufc::function was replaced by tabulate_reference_dof_coordinates + map_dofs (transform_values since #32). This made it basically defunct for multiple points dofs. Examples

element = FiniteElement("Nedelec 1st kind H(curl)", triangle, 2)
element = FiniteElement("Nedelec 1st kind H(curl)", tetrahedron, 3)
element = FiniteElement("Nedelec 2nd kind H(curl)", triangle, 2)
element = FiniteElement("Nedelec 2nd kind H(curl)", tetrahedron, 2)

which since that do not support interpolation because dofs are multi-point.

Note that these examples in fact currently crash on a trivially fixable assertion when compiled.

How to reproduce:

cat - > e.ufl <<EOF
element = FiniteElement("Nedelec 1st kind H(curl)", triangle, 2)
EOF

python3 -mffc e.ufl

# observe that implementation of transform_values is junk, will not compile
@blechta blechta added bug Something isn't working enhancement New feature or request labels Jun 8, 2018
@blechta
Copy link
Member Author

blechta commented Jun 12, 2018

Agreed design goals:

  • Add interpolation function to new ufc_function_space struct.
  • Must support vectorised evaluation.
  • Consider non-affine elements.
  • Rename to something sensible, e.g., interpolation_operator

@garth-wells garth-wells changed the title Redesign FE interpolation (and make it again working for multi point dofs) Redesign FE interpolation (and get it working again for multi-point dofs) Jul 12, 2018
@blechta blechta self-assigned this Jul 17, 2018
@blechta blechta removed their assignment Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant