Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flash focus while using tabbed in i3 #64

Open
huyhoang8398 opened this issue Jul 7, 2021 · 3 comments
Open

Disable flash focus while using tabbed in i3 #64

huyhoang8398 opened this issue Jul 7, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@huyhoang8398
Copy link

huyhoang8398 commented Jul 7, 2021

Can we disable flash focus while using tabbed layout in i3?

@fennerm
Copy link
Owner

fennerm commented Jul 7, 2021

@huyhoang8398 could you describe the behavior you'd like in a bit more detail? Specifically are you saying you would like windows not to flash when you change tabs? or would you like windows to never flash if they have tabs?

I'm slightly hesitant to add i3-specific features but I'm open to it if the implementation is not too complex.

@huyhoang8398
Copy link
Author

huyhoang8398 commented Jul 7, 2021

2021-07-07.22-43-05.mp4

I usually use tabbed layout as in the video, and for me i dont think it need to flash the window in tabbed layout because we already have the tab name on top of the window stack

@fennerm
Copy link
Owner

fennerm commented Jul 18, 2021

Thanks for the added detail @huyhoang8398. I don't use i3 (or tabbed windows) so I don't think I'll take this on personally. I do think this is a good feature though and I would accept a PR.

Some hints for what would be needed here:

  • Some way to detect that a user is using i3 in flashfocus.compat
  • A new config option and CLI argument
  • A method in flashfocus.display_protocols for checking whether a window is tabbed
  • Some logic in flashfocus.router to exempt tabs from flashing.

@fennerm fennerm added the help wanted Extra attention is needed label Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants