Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreading #38

Closed
fennifith opened this issue Jul 25, 2018 · 6 comments
Closed

Multithreading #38

fennifith opened this issue Jul 25, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@fennifith
Copy link
Owner

Multiple threads. Multithreading. The act of having more than one thread at a single point in time.

@fennifith fennifith added the enhancement New feature or request label Jul 25, 2018
@fennifith
Copy link
Owner Author

This was originally created because I thought that there was about a second of lag upon opening the screen. However, it may have been caused by a different issue entirely.

Upon looking into it, I decided to take a quick look at the GitHubData class to see if I could make it any faster at fetching information, and I realized that... it wasn't caching any of the requests. Why? The folder that it was storing the cache in didn't exist.

So commit f818f1f may have resolved this. I'm going to leave it open for a bit and see how the changes affect some of Attribouter's implementations though, just in case there is anything else I can do.

@rroyGit
Copy link
Contributor

rroyGit commented Aug 11, 2018

If it's not solved, I give it a try

@fennifith
Copy link
Owner Author

@rroyGit if you have time to waste and don't mind digging around in my ridiculous code style to find things to improve, go right ahead.

@rroyGit
Copy link
Contributor

rroyGit commented Aug 16, 2018

just submitted a PR, can you test with changes? I haven't done too much testing, got some problems when adding the library externally to Android Studio and API compatibility problems when using the library.

Thanks

@rroyGit
Copy link
Contributor

rroyGit commented Aug 16, 2018

Yo, I was wondering for GitHubData class, when creating the class object is it possible to pass the context at that time? If yes, I would like to try moving threads around in that class.
Could you also pinpoint me where you are creating the GitHubData objects? Thanks.

@fennifith
Copy link
Owner Author

@rroyGit GitHubData's subclasses are created in the "-Wedge" classes. They're then passed to addRequest and end up in the AttribouterFragment, which adds them to a List and starts them only if they don't already exist in the list (if the same 'request' is created by two Wedges, for example). Otherwise, it either merges them together by combining their listeners, or if the request is finished it just sends it back to the Wedge through onInit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants