Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mesh instance name in rendering #23

Closed
terrac opened this issue Mar 27, 2017 · 1 comment
Closed

Make mesh instance name in rendering #23

terrac opened this issue Mar 27, 2017 · 1 comment

Comments

@terrac
Copy link
Contributor

terrac commented Mar 27, 2017

On line 254 in rendering.js I noticed that it is passing a name mesh.createInstance(name), but that name doesn't seem to be set in the function it is being called from.

I don't know if that might have a negative side effect in some cases, but it doesn't look correct to me.

Thanks

@fenomas
Copy link
Owner

fenomas commented Mar 30, 2017

Great find, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants