Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter::from_multiple_json fails when components exist in multiple files #193

Closed
prehner opened this issue Oct 12, 2023 · 0 comments · Fixed by #196
Closed

Parameter::from_multiple_json fails when components exist in multiple files #193

prehner opened this issue Oct 12, 2023 · 0 comments · Fixed by #196
Labels
bug Something isn't working core related to features in feos-core
Milestone
v0.5.0

Comments

@prehner
Copy link
Contributor

prehner commented Oct 12, 2023

grafik

In this case the CO2 parameters are the one from gross2001.json. It looks like in the routine the records are overriden.
@prehner prehner added bug Something isn't working core related to features in feos-core labels Oct 12, 2023
@prehner prehner added this to the v0.5.0 milestone Oct 12, 2023
@prehner prehner linked a pull request Oct 18, 2023 that will close this issue
Add json parser for Vec<PureRecords> #196
Merged
@prehner prehner closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working core related to features in feos-core
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Add json parser for Vec<PureRecords> feos-org/feos
1 participant
@prehner