Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoking stop-fn with nil when start fails #3

Open
ferdinand-beyer opened this issue Jul 20, 2022 · 0 comments
Open

Invoking stop-fn with nil when start fails #3

ferdinand-beyer opened this issue Jul 20, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ferdinand-beyer
Copy link
Owner

When a start function throws, init.system/start-component will attempt to stop all already started components, in reverse dependency order.

However, this calculation seems to be wrong, as I see suppressed NullPointerExceptions.

We should limit the reverse-dependency-order to the set of keys in the system at the time of error.
@ferdinand-beyer ferdinand-beyer added the bug Something isn't working label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ferdinand-beyer