Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] tvOS scrolling issue #237

Closed
staticdreams opened this issue Oct 28, 2021 · 2 comments · Fixed by #240
Closed

[BUG] tvOS scrolling issue #237

staticdreams opened this issue Oct 28, 2021 · 2 comments · Fixed by #240
Labels
bug Something isn't working

Comments

@staticdreams
Copy link

Describe the bug
Installed as expected using SPM.
Unable to scroll on tvOS even though package claims to be tvOS compatible.

To Reproduce
Implement a basic example with focusable areas, such as NavigationLink

Expected behaviour
Expected to scroll left or right using Apple TV Remote, just like on a standard ScrollView. Also expected to center focused item

Screenshots / Videos
On the screenshot, left item is in focus. It is not centered and unable to scroll to the left, beyond this item (there a total of 5 in the pager)

Simulator Screen Shot - Apple TV 4K (2nd generation) - 2021-10-28 at 09 18 48

Environment:

  • tvOS 15.1
  • AppleTV 4k
  • SwiftUIPager version: 2.3.1
@staticdreams staticdreams added the bug Something isn't working label Oct 28, 2021
@fermoya
Copy link
Owner

fermoya commented Nov 15, 2021

Hi @staticdreams , you're right, thanks for raising this. I wasn't aware of the special treat that tvOS and potentially macOS need. I'm fixing this, will come to you shortly

@fermoya fermoya linked a pull request Nov 16, 2021 that will close this issue
@HenryGlendening
Copy link

I'm experiencing this issue while running the latest code. I think the patch (#240) allows the user to change which Page is focused by using the Apple TV Remote arrow buttons (on the newer Apple TV Remotes), however, swiping on the remote does not scroll the Page or otherwise respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants