Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases: update test components Cargo.lock? #2261

Open
vdice opened this issue Jan 30, 2024 · 0 comments
Open

Releases: update test components Cargo.lock? #2261

vdice opened this issue Jan 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vdice
Copy link
Member

vdice commented Jan 30, 2024

See #2260 (comment)

When bumping the Spin version for a release (seen recently in #2260), the Lint check failed with:

...
M	tests/test-components/components/Cargo.lock
Git working tree dirtied by lints. Run 'make update-cargo-locks' and check in changes

The release docs inform to run make update-cargo-locks, but this target currently only appears to update the top-level Cargo.lock and those under examples... Do we need to add tests as well?

@vdice vdice changed the title Releases: update test components Cargo.locks? Releases: update test components Cargo.lock? Jan 30, 2024
@vdice vdice moved this to 🆕 Triage Needed in Spin Triage Mar 13, 2024
@vdice vdice moved this from 🆕 Triage Needed to 🔖 Backlog in Spin Triage Mar 13, 2024
@vdice vdice added the bug Something isn't working label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🔖 Backlog
Development

No branches or pull requests

1 participant